Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConsider improving the performance of Microsoft.AspNetCore.Mvc.Versioning.QueryStringApiVersionReader #690
Assignees
Labels
Comments
|
This is not an unreasonable enhancement. I've converted many iterator loops to indexing loops, but there's still a few left. This is was one of the earlier bits of code. I'll review all of the readers for potential optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Readmethod ofMicrosoft.AspNetCore.Mvc.Versioning.QueryStringApiVersionReaderunconditionally instantiates anHashSet<string>regardless of having a version specified or not with the only purpose of invokingCollectionExtensions.EnsureZeroOrOneApiVersions.CollectionExtensions.EnsureZeroOrOneApiVersionsusesEnumerable.SingleOrDefaultto returnnull, if the hash set is empty; and its single item if it isn't.Enumerable.SingleOrDefaulthas optimizations forIList<T>, but not forICollection<T>, which requires the instantiation and boxing ofHashSet<T>.Enumerator.All this could be optimized by only instantiating the
HashSet<string>if 2 or more different versions are found and having an extension method to report the error that takes anHashSet<string>for the optimized construction of the list of versions.