Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDefining behaviour for error data payloads #741
Comments
|
I totally agree that the string representation of the error message is more than useless. Unfortunately, spec limits body to -> (https://github.com/rsocket/rsocket/blob/master/Protocol.md#error-frame-0x0b)
So far, I propose to add your input here -> rsocket/rsocket#282 |
|
Hey, Oleg! Thanks! To clarify, at the moment I'm generally happy with the arbitrary payload encoded as an UTF-8 string. The issue that I'm facing is that there is no explicit way for me to specify what should be in this payload through rsocket-java API. |
|
Gotcha! Will be refined today |
Hey, Folks!
As far as I can see, rsocket allows for sending arbitrary payloads inside the error frame,
Error Data, as long as it's encoded in UTF-8. At the moment, rsocket-java encodes the exception message into theError Datafield.rsocket-java/rsocket-core/src/main/java/io/rsocket/frame/ErrorFrameFlyweight.java
Line 39 in 3f5b304
I'm planning on using a custom error code to define a "structured" payload which includes a json-encoded object with multiple fields. It's easily achievable by creating a custom rsocket exception, thanks to #727, with a special message, e.g.
However, the way of doing this isn't well-defined, and the behaviour might change in future. What do you think of defining this behaviour explicitly, similarly to this POC: SerCeMan@1c7df73? Alternatively, maybe it would be better to add javadoc documenting the behaviour on the exception itself.