Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMailSender doesn't correctly set JavaMail properties for SMTPS connections #111
Comments
cbarcenas
changed the title
|
Indeed, quoting javaee:
I agree, these properties will need to come from the |
|
Now that I think about it, why don't we scrap the per-property interface and instead add a single |
|
I like the flexibility it gives me in case the property is completely different per transport strategy. Of course this will never happen with this decades old specification, so it is kind of moot. However, I like this design, it's clear enough (and I've already updated it). |
|
Cool, I'm pretty indifferent either way |
|
Actually, this was rather tricky, since the transport strategy is an optional parameter in favor of a preconfigured provided Session object. In one type of scenario an exception was in order, in a second skipping defaults and in a third skipping properties logging they were assumed to be preconfigured. |
…rt Strategy while also handle various scenario's where Transport Strategy was not provided
|
Released as 5.0.0.rc1-SNAPSHOT. Add OSS' snapshots repo to find it in Maven. |
Several of the configuration methods in
MailSenderincorrectly set JavaMail properties under themail.smtpprefix whensmtpsmail transport (TransportStrategy.SMTP_SSL) is used. I'm pretty sure themail.smtpsprefix should be used instead.Examples: [1] [2] [3] [4]
The cleanest fix, I think, is to implement additional abstract property name getters under the
TransportStrategyenum.