The Wayback Machine - https://web.archive.org/web/20220408035456/https://github.com/roboll/helmfile/pull/1268
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace getOrNil with get function in documentation #1268

Merged
merged 10 commits into from Jun 7, 2020
Merged

Replace getOrNil with get function in documentation #1268

merged 10 commits into from Jun 7, 2020

Conversation

renehernandez
Copy link
Contributor

@renehernandez renehernandez commented May 21, 2020

Fix #1267
@renehernandez
Copy link
Contributor Author

@renehernandez renehernandez commented May 28, 2020

@mumoshu Any update on this?
@renehernandez
Copy link
Contributor Author

@renehernandez renehernandez commented Jun 5, 2020

@mumoshu Is there anything else required to get this in?
@mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jun 5, 2020

@renehernandez Sorry for the delay! This looks almost good. If you could address the only comment I made here #1268 (comment), I'll merge this shortly.

Thanks for your patience and contribution!
mumoshu
mumoshu approved these changes Jun 7, 2020
View changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

LGTM. Thanks a lot for your contribution!
@mumoshu mumoshu merged commit 604af3f into roboll:master Jun 7, 2020
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@renehernandez @mumoshu