Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: add async test case #339
Merged
Conversation
|
从代码到测试都可以用 aa |
Closed
| "extends": "eslint-config-egg" | ||
| "extends": "eslint-config-egg", | ||
| "parserOptions": { | ||
| "ecmaVersion": 2017 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dead-horse
Feb 9, 2017
Author
Member
在 test/async/_async.js 里面也有用，感觉还是把它放到 eslint-config-egg 里面吧，不然别人用 node 7 + async 就比较麻烦了。
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| const nodeVersion = Number(process.version.match(/^v(\d+\.\d)+\./)[1]); | ||
| // only node >= 7.6 support async function without flags | ||
| if (nodeVersion >= 7.6) { |
This comment has been minimized.
This comment has been minimized.
|
schedule 也加个？ |
codecov
bot
commented
Feb 9, 2017
Codecov Report@@ Coverage Diff @@
## master #339 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 28
Lines 635 635
=====================================
Hits 635 635Continue to review full report at Codecov.
|
codecov
bot
commented
Feb 9, 2017
•
Codecov Report@@ Coverage Diff @@
## master #339 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 28
Lines 635 635
=====================================
Hits 635 635Continue to review full report at Codecov.
|
|
schedule 加了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dead-horse commentedFeb 9, 2017
•
edited by fengmk2
Checklist
npm testpassesAffected core subsystem(s)
test
Description of change
增加 async 相关的测试用例，需要等 egg-core 发布新版和 node 7.6 发布。