Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse inbound peerslot slots when a substream is received, rather than a connection #7464
Conversation
|
Sorry for the lack of thorough explanations at the moment. This PR was very tiring to make, and I'm just very happy/relieved to finally open it and shut down my IDE. I'll edit the OP to provide more context tomorrow or next week. |
|
Marked as ready for CI purposes only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix #7074
This implements the change described in #7074.
It took me a lot of time, but I came up with this refactoring of the communication between the behaviour and the handler. I believe that the new asynchronous protocol between the behaviour and handler is sound, in other words that it is not prone to race conditions.
I invite you to look at the documentation of
group.rsfor explanations.The implementation of this new protocol, though, seems faulty. I'm opening as a draft because I know that tests aren't passing, and I want to do more re-review, debugging, and styling passes myself.
@romanb @mxinden (or any other reviewer)
Feel free to comment now about at the new protocol explained on top of
group.rs, if you wish so.The exact code changes are still to follow.