The Wayback Machine - https://web.archive.org/web/20201101035318/https://github.com/catchorg/Catch2/issues/2075
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our CI should check that all files use proper include guards #2075

Open
horenmar opened this issue Oct 29, 2020 · 0 comments
Open

Our CI should check that all files use proper include guards #2075

horenmar opened this issue Oct 29, 2020 · 0 comments

Comments

@horenmar
Copy link
Member

@horenmar horenmar commented Oct 29, 2020

As part of cleanup efforts in the devel branch, I standardized the include guards of all headers to obey simple pattern: ${UPPER_CASE_FILENAME}_INCLUDED.

To avoid non-standard include guards in the future, we should make this check a part of the automatic per-commit CI. I originally used checkguard Python tool for this check, but other tools can also be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.