Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Properly set ItemContainerStyle for ListBox #922 #2142
Merged
Conversation
Keboo
merged commit 7253d0f
into
MaterialDesignInXAML:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #922
One can check that the issue described in #922 does not exist when using
ListViewin place ofListBox. I compared the default styles set by MDinXAML forListBoxandListView. I concluded that the problem does not exist forListViewbecause it sets theItemContainerStyleproperty whileListBoxdoes not. That property setter uses a converter, which makes things a bit more complicated, but in the cases I tested, the converter always returned the style with keyMaterialDesignListBoxItem, which is the default style set by MDinXAML forListBoxItem.This PR sets the
ItemContainerStyleproperty to the style with keyMaterialDesignListBoxItemon the default style forListBox. I verified locally that this fixes #922.I am willing to also add a test for this if someone can provide me a bit of assistance by showing me what such a test should look like.