src: expose v8::Isolate setup callbacks #35512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
the
embedding
nodejs-github-bot
added
the
c++
codebytere
force-pushed
the
expose-isolate-callbacks
branch
from
587468a
to
d28751c
Compare
devsnek
approved these changes
Oct 5, 2020
juanarbol
approved these changes
Oct 6, 2020
github-actions
bot
removed
the
request-ci
addaleax
requested changes
Oct 6, 2020
I’m definitely node.h instead of the internal Environment class (and use NODE_EXTERN)
Can you move that to |
addaleax
added
the
semver-minor
codebytere
force-pushed
the
expose-isolate-callbacks
branch
from
d28751c
to
48ecb02
Compare
codebytere
force-pushed
the
expose-isolate-callbacks
branch
from
48ecb02
to
09cf132
Compare
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Oct 7, 2020
addaleax
added
the
author ready
|
Landed in ccc822c |
codebytere
added a commit
that referenced
this issue
Oct 8, 2020
PR-URL: #35512 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this issue
Oct 13, 2020
PR-URL: #35512 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
added a commit
that referenced
this issue
Oct 14, 2020
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) #35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) #35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: TODO
Merged
MylesBorins
added a commit
that referenced
this issue
Oct 15, 2020
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) #35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) #35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: TODO
MylesBorins
added a commit
that referenced
this issue
Oct 15, 2020
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) #35546 doc: * add aduh95 to collaborators (Antoine du Hamel) #35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) #35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) #35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) #35512 PR-URL: #35648
1 task
1 task
1 task
1 task
Closed
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR makes some more of the
v8::Isolate*setup callbacks used by Node.js to external embedders. We already possess the ability to override the callbacks used, but there are some situations in which we would still want to access Node.js' default behavior.For example: in an Electron renderer process, the context currently in play would not have been subject to some of the
ContextEmbedderDatadata set by Node.js, but thev8::Isolatewould assume that it had and make erroneous choices as a result. As such, in this situation, we would tell the isolate to make different choices in the callback depending on the current process. We could, of course, simply copy over the code, but we then run the risk of missing future changes to this callback logic. There is also precedent for this - we can already accesstask_queue::PromiseRejectCallbackfor similar ends.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes