The Wayback Machine - https://web.archive.org/web/20201216190014/https://github.com/electron/fiddle/pull/504
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use GitHub Actions to build #504

Merged
merged 10 commits into from Oct 19, 2020
Merged

build: Use GitHub Actions to build #504

merged 10 commits into from Oct 19, 2020

Conversation

@felixrieseberg
Copy link
Member

@felixrieseberg felixrieseberg commented Oct 19, 2020

This PR moves our build infrastructure from Travis & AppVeyor over to GitHub Actions. I have also updated our repository secrets with a new three-year certificate. I'm pretty confident in the code, it's already running various of my personal projects well.

This shouldn't change anything, but we should check that everything got correctly signed the next time we release a new version.

Copy link
Member

@erickzhao erickzhao left a comment

Seems like all the :octocat: checks are green

Other TODO (could wait for later):

  • Update badges in README
  • Handle Coveralls for code coverage (used to be in TravisCI)
  • Remove CircleCI/Travis/Appveyor checks (cc @malept does this PR overtake #360?)
@malept
Copy link
Member

@malept malept commented Oct 19, 2020

* Remove CircleCI/Travis/Appveyor checks (cc @malept does this PR overtake #360?)

Yes, and also GitHub Actions is way better IMO

Copy link
Member

@malept malept left a comment

For what it's worth, I have been working on Actions to make building Electron Forge projects in GitHub Actions way simpler, based on conversations I've had with Felix regarding one of his more recent projects. I can make a PR against this one to show what the changes would be, if y'all want. Or since I won't be able to get to it until late tonight, I can just make a normal PR after this is merged.

- name: Git Submodules
run: git submodule update --init --recursive
Comment on lines 80 to 81

This comment has been minimized.

@malept

malept Oct 19, 2020
Member

I didn't realize Fiddle used git submodules...

This comment has been minimized.

@felixrieseberg

felixrieseberg Oct 19, 2020
Author Member

Oh, it doesn't, that's a copy & paste fragment. Thanks for catching.

@coveralls
Copy link

@coveralls coveralls commented Oct 19, 2020

Coverage Status

Coverage remained the same at 93.919% when pulling 57da2b3 on gh-build into e40a296 on master.

@felixrieseberg felixrieseberg merged commit 6a7decd into master Oct 19, 2020
5 of 7 checks passed
5 of 7 checks passed
test
Details
Build (macOS-latest) Build (macOS-latest)
Details
Build (ubuntu-latest)
Details
Build (windows-latest) Build (windows-latest)
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
coverage/coveralls Coverage remained the same at 93.919%
Details
@felixrieseberg felixrieseberg deleted the gh-build branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.