Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTimestamper should allow providing our own timestamp #81
Comments
|
That would slow it down for everyone. But you can work around pretty easily yourself without reimplementing anything (untested but should work): class MaybeTimestamper(object):
def __init__(self):
self. stamper = structlog.processors.TimeStamper()
def __call__(self, l, m, ev:):
if "timestamp" not in ev:
return self.stamper(l, m, ev)
return evAm I missing something? |
I know that calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL; DR: it would be convenient in some rare cases to allow providing our own timestamp. Right now, I need to reimplement
structlog.processors.TimeStamperto do achieve this.I'm writing a toy microservices PaaS (purely for educative purposes) and I'm currently working on request tracing for correlation of events across multiple services. The idea is that each service logs the request URL path, HTTP response status, processing time and request ID for each HTTP request so I an understand where errors are coming from (nothing new here).
Now that I've got something working, I noticed that events show up in a rather confusing order: since I log at request completion time to get the response status code, the timestamp of the request causes an order which looks time ordered across requests, but the order is reversed for sub-requests, which complete before the enclosing/source request (the one at the edge of the network).
It's trivial for me to record the arrival time of the request, so I'd like to use that and inject it in the event data I pass to
logger.info('http.access', path=..., status=..., processing_time=..., timestamp=...).From the looks of it, adding support for this is mostly replacing a few
event_dict[key] = ...statements toevent_dict.setdefault(key, ...), plus some docs to explain that the caller is responsible for formatting the timestamps themselves when they use this (OK for me, I always log iso anyways).Would you be open to such a change? I'm willing to put in a PR if you're OK with this proposal :-)