Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: add onerror test cases to policy #35797
Closed
Conversation
watilde
changed the title
|
@watilde are you able to follow these updated instructions, to check coverage locally? |
This comment has been hidden.
This comment has been hidden.
Increase test coverage of lib/internal/policy/manifest.js
|
@bcoe That doc is v good to know! I ran in my local now and could confirm the coverage was increased as expected with my last pushed commit: |
This comment has been hidden.
This comment has been hidden.
Commit Queue failed- Loading data for nodejs/node/pull/35797 ✔ Done loading data for nodejs/node/pull/35797 ----------------------------------- PR info ------------------------------------ Title test: add onerror test cases to policy (#35797) Author Daijiro Wachi (@watilde) Branch watilde:test-policy-onerror -> nodejs:master Labels author ready, policy, test Commits 1 - test: add onerror test cases to policy Committers 1 - Daijiro Wachi PR-URL: https://github.com/nodejs/node/pull/35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe Reviewed-By: James M Snell Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe Reviewed-By: James M Snell Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-27T14:36:48Z: https://ci.nodejs.org/job/node-test-pull-request/33886/ - Querying data for job/node-test-pull-request/33886/ ✔ Build data downloaded - Querying failures of job/node-test-commit/41685/ ✔ Data downloaded ✖ 3 failure(s) on the last Jenkins CI run ℹ This PR was created on Sun, 25 Oct 2020 14:14:02 GMT ✔ Approvals: 3 ✔ - Ben Coe (@bcoe): https://github.com/nodejs/node/pull/35797#pullrequestreview-516404681 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35797#pullrequestreview-516924772 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35797#pullrequestreview-518679268 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/334784370 |
This comment has been hidden.
This comment has been hidden.
watilde
added a commit
that referenced
this pull request
Oct 29, 2020
Increase test coverage of lib/internal/policy/manifest.js PR-URL: #35797 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60 Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 802c98d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Increase test coverage of
lib/internal/policy/manifest.jsRefs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L60
Refs: https://coverage.nodejs.org/coverage-642f2064c06793b7/lib/internal/policy/manifest.js.html#L146
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes