The Wayback Machine - https://web.archive.org/web/20200915122413/https://github.com/LeetCode-OpenSource/vscode-leetcode/pull/601
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: star command in shortcuts #601

Merged
merged 3 commits into from Jul 21, 2020
Merged

Conversation

@yihong0618
Copy link
Contributor

yihong0618 commented Jul 19, 2020

@jdneo @zry656565
Support star/unstar in codelen shortcuts/
image

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jul 19, 2020

Support #598 #549

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

Thanks @yihong0618

I would suggest to use $(star-empty) and $(star-full). You can find the style here: https://microsoft.github.io/vscode-codicons/dist/codicon.html

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jul 20, 2020

@jdneo
Seems a bit low then the text title(Submit, Test)?
And is it necessary to change heart icon to star icon too?
image

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

Ok, given the current rendering result, seems using text is better. But I think there is no need to put it as one of the default value

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jul 20, 2020

Ok, given the current rendering result, seems using text is better. But I think there is no need to put it as one of the default value

Maybe in setting that user can config it open it or not?

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

Do you mean using a setting to toggle between text and icon?

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jul 20, 2020

Do you mean using a setting to toggle between text and icon?

Forget it, I think for now, keep the text maybe a better way.

@jdneo
Copy link
Member

jdneo commented Jul 20, 2020

I think so too.

@@ -621,7 +621,8 @@
"type": "array",
"default": [
"submit",
"test"
"test",
"star"

This comment has been minimized.

@jdneo

jdneo Jul 20, 2020

Member

No need to add this shortcut by default. But please add it in the items, and also documents in readme

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jul 20, 2020

@jdneo Fixed.

README.md Outdated
- `Submit`: Submit your answer to LeetCode.
- `Test`: Test your answer with customized test cases.
- `Star/Unstar`: Star or Unstar the current problem.

This comment has been minimized.

@jdneo

jdneo Jul 20, 2020

Member

nit: unstar

@@ -629,6 +629,7 @@
"enum": [

This comment has been minimized.

@jdneo

jdneo Jul 20, 2020

Member

Could you by the way add "enumDescriptions" for this setting here? 😄

This comment has been minimized.

@yihong0618

yihong0618 Jul 20, 2020

Author Contributor

Fixed, and optimize star logic.

@jdneo
jdneo approved these changes Jul 21, 2020
Copy link
Member

jdneo left a comment

Thanks @yihong0618 !

@jdneo jdneo merged commit ade48fb into LeetCode-OpenSource:master Jul 21, 2020
3 checks passed
3 checks passed
LGTM analysis: JavaScript No new or fixed alerts
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdneo jdneo added this to the 0.17.1 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.