The Wayback Machine - https://web.archive.org/web/20201009225620/https://github.com/VSCodeVim/Vim/issues/3638
Skip to content

/ Vim

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support :bd to close current buffer #3638

Open
paulgreg opened this issue Mar 29, 2019 · 7 comments
Open

Support :bd to close current buffer #3638

paulgreg opened this issue Mar 29, 2019 · 7 comments
Labels
area/commandline good first issue kind/enhancement

Comments

@paulgreg
Copy link

@paulgreg paulgreg commented Mar 29, 2019

Is your feature request related to a problem? Please describe.
Under VIM, I’m used to type :bd to close the current file/buffer.
That command isn’t working under VSCodeVim : Not and editor command bd
To close the current buffer, only :q works which isn’t correct : :q under VIM close VIM (and all files/buffers opened)
:bd seems a better command to close the current file/buffer.

Describe the solution you'd like
I would like that :bd close the current file/buffer.
Ideally, :q should close VSCodeVim, like what VIM is doing (but I understood it’s quite a change for people used to)

Describe alternatives you've considered
No idea

Additional context
I think it’s important because VSCodeVim « learns » you to use :q to close current buffer which is not correct under vim. So, if you’re using VIM later on, you could close VIM by « habit ».
@jay-khatri
Copy link

@jay-khatri jay-khatri commented Aug 10, 2019 •
edited

@J-Fields Could I take a crack at this? From what I understand, I'll need to create a new buffer.ts in commands/ and /subparsers.

Also, just to confirm, in VScode, we're treating open tabs as buffers?

cc @paulgreg
@J-Fields
Copy link
Collaborator

@J-Fields J-Fields commented Aug 19, 2019

@jay-khatri Sure; that looks right. Yeah tabs VSCode tabs map to vim buffers.
@J-Fields J-Fields removed the Hacktoberfest label Dec 14, 2019
@vedran
Copy link

@vedran vedran commented Jan 2, 2020

@jay-khatri are you still doing this one? If not, I'm interested in taking it over. Thanks!
(cc @J-Fields)
@th-ad
Copy link

@th-ad th-ad commented Jan 3, 2020

Traditionally, :bd would behave by closing all windows to a certain buffer. Because VSCode tabs map to buffers (not windows), would that not be the case here?
@th-ad
Copy link

@th-ad th-ad commented Jan 6, 2020

@vedran Are you working on this right now? I have some ideas about how this feature should function. I would be happy to take it off your hands! (@J-Fields)
@jay-khatri
Copy link

@jay-khatri jay-khatri commented Jan 6, 2020

@vedran @th-ad Haven't gotten a chance to get a PR out, its is up for grabs :).
@vedran
Copy link

@vedran vedran commented Jan 7, 2020 •
edited

@th-ad I haven't started on it yet, was planning to next weekend. If you've already spent some time thinking about it, feel free to take it :)
@th-ad th-ad mentioned this issue Jan 7, 2020
Open
@vedran vedran removed their assignment Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/commandline good first issue kind/enhancement
5 participants
@paulgreg @vedran @J-Fields @jay-khatri @th-ad
You can’t perform that action at this time.