Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix several warnings in the diff example #135
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Thanks for the PR, I’ll take a look this week |
|
Thanks for fixing those warnings, this looks good. The context manager change lgtm. |
|
Thanks for the review. I will open a PR for the Python documentation, good idea. |
|
sgtm, let's remove the open mode.
Great, thanks. cc me, or drop a link to the PR in this issue once it's open? |
|
Sure :) |
|
checking in on removing the open mode |
|
Sorry, I will have time this week-end :)
|
|
Okay Sounds good |
|
I aligned the script with the Python 3 version. WDYT? |
|
lgtm, |
54f91a2
into
google:master
|
All set, thanks! |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Fixes ResourceWarning unclosed file:
And DeprecationWarning 'U' mode is deprecated: