The Wayback Machine - https://web.archive.org/web/20201110142556/https://github.com/github/markup/pull/1290
Skip to content

/ markup

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether filename is set when rendering asciidoc. Resolves #1289 #1290

Merged
merged 1 commit into from Sep 5, 2019
Merged

Check whether filename is set when rendering asciidoc. Resolves #1289 #1290

merged 1 commit into from Sep 5, 2019

Conversation

@dometto
Copy link
Contributor

@dometto dometto commented Sep 4, 2019

I used @mojavelinux's snippet from issue #1289, but also added a test for good measure.
@dometto
Check whether filename is set when rendering asciidoc
Loading status checks…
2710ab9
@dometto
Copy link
Contributor Author

@dometto dometto commented Sep 4, 2019

Test failures seem unrelated
@mojavelinux
Copy link
Collaborator

@mojavelinux mojavelinux commented Sep 4, 2019

LGTM!
@kivikakk
Copy link
Contributor

@kivikakk kivikakk commented Sep 5, 2019

LGTM. Test failures are indeed unrelated.
@kivikakk
kivikakk approved these changes Sep 5, 2019
View changes
@kivikakk kivikakk merged commit cd01f9e into github:master Sep 5, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@sara2085788

This comment has been minimized.

Sign in to view
Copy link

@sara2085788 sara2085788 commented on 2710ab9 Feb 7, 2020

5 prueba / markup_test.rb

@@ -94,7 +94,10 @@ def test_each_render_has_a_name
final

def test_rendering_by_symbol
afirmar_equal '

prueba

' , GitHub :: Markup . render_s ( GitHub :: Markups :: MARKUP_MARKDOWN , '' prueba` ' ) . tira
marcado = '' prueba ''
resultado = /

prueba < \ / code> < \ / p> /
Aserción del resultado de coincidencia , GitHub :: Markup . render_s ( GitHub :: Markups :: MARKUP_MARKDOWN , marcado ) . tira
Aserción del resultado de coincidencia , GitHub :: Markup . render_s ( GitHub :: Markups :: MARKUP_ASCIIDOC , marcado ) . dividir . unirse
final

def test_raises_error_if_command_exits_non_zero
@ahmed1231234

This comment has been minimized.

Sign in to view
Copy link

@ahmed1231234 ahmed1231234 commented on lib/github/markups.rb in 2710ab9 Mar 1, 2020

https://github.com/facebookarchive/facebook-swift-sdk.git
@dometto dometto mentioned this pull request Apr 30, 2020
Open
@dometto
Copy link
Contributor Author

@dometto dometto commented May 1, 2020

@kivikakk It's been a while, but could you perhaps cut a bugfix release that includes the changes in this PR? Thanks!
@kivikakk
Copy link
Contributor

@kivikakk kivikakk commented May 1, 2020

Hi @dometto — unfortunately I no longer work for GitHub and don’t have write access to the gem any more. I’m not sure who does; you may need to contact support to find out who can help with this now.
@pdinc-oss
Copy link

@pdinc-oss pdinc-oss commented Nov 9, 2020 •
edited

@Alhadis ping... I see that you seem to have picked up the torch recently. Any chance of doing a bug fix release?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants
@dometto @mojavelinux @kivikakk @pdinc-oss @ahmed1231234 @sara2085788
You can’t perform that action at this time.