The Wayback Machine - https://web.archive.org/web/20201125085929/https://github.com/SheetJS/sheetjs/pull/2003
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING doc for opening pull requests #2003

Merged
merged 1 commit into from Jun 12, 2020
Merged

Conversation

@srijonsaha
Copy link
Contributor

@srijonsaha srijonsaha commented Jun 12, 2020

Add info about [ci skip] to avoid travis ci and commits should also be squashed.

Copy link
Contributor

@garrettluu garrettluu left a comment

Looks good, I would just add a note about using git rebase to squash commits.

@srijonsaha srijonsaha force-pushed the contributing-doc branch from 931b98a to 422f046 Jun 12, 2020
Copy link
Contributor

@garrettluu garrettluu left a comment

Looks good to me!

@garrettluu garrettluu merged commit cdfe678 into master Jun 12, 2020
@srijonsaha srijonsaha deleted the contributing-doc branch Jun 12, 2020
@srijonsaha srijonsaha self-assigned this Jun 26, 2020
saarCiklum added a commit to Folcon/js-xlsx that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.