The Wayback Machine - https://web.archive.org/web/20200915122409/https://github.com/LeetCode-OpenSource/vscode-leetcode/pull/171
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github issue templates #171

Merged
merged 4 commits into from Mar 3, 2019
Merged

Conversation

@poppinlp
Copy link
Contributor

poppinlp commented Mar 1, 2019

This PR is for #169
I've added 4 issue templates.

  • bug.md: For bug report.
  • feature.md: For feature request.
  • question.md: For question.
  • ISSUE_TEMPLATE.md: If the user chooses to create a regular issue.
poppinlp and others added 2 commits Mar 1, 2019
- *extension settings*:
- *nodejs version*:
- *vscode version*:
- *extension version*:

This comment has been minimized.

@jdneo

jdneo Mar 2, 2019

Member

Also, add the expected behavior and the actual behavior?

Copy link
Member

jdneo left a comment

Looks fine, just some comments...

Please add the .github folder into the .vscodeignore so that we won't package the content into the *.vsix

Thanks.

@poppinlp
Copy link
Contributor Author

poppinlp commented Mar 3, 2019

  • Add .github in .vscodeignore(sry for forgot that)
  • Add reproduce step and expected behavior in bug.md

I think we could get the information for the actual behavior from the bug description, so I just add the reproduce step and expected behavior. What do you think? :)

@jdneo
jdneo approved these changes Mar 3, 2019
Copy link
Member

jdneo left a comment

LGTM

@jdneo jdneo merged commit d3d522a into LeetCode-OpenSource:master Mar 3, 2019
2 checks passed
2 checks passed
LGTM analysis: JavaScript No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdneo jdneo added this to the 0.12.0 milestone Mar 3, 2019
@poppinlp poppinlp deleted the poppinlp:issue169 branch Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.