The Wayback Machine - https://web.archive.org/web/20201223144337/https://github.com/freeCodeCamp/devdocs/pull/1236
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for OCaml #1236

Open
wants to merge 2 commits into
base: master
from
Open

Add documentation for OCaml #1236

wants to merge 2 commits into from

Conversation

@seirl
Copy link

@seirl seirl commented May 24, 2020

If you’re adding a new scraper, please ensure that you have:

  • Tested the scraper on a local copy of DevDocs
  • Ensured that the docs are styled similarly to other docs on DevDocs
  • Added these files to the public/icons/your_scraper_name/ directory:
    • 16.png: a 16×16 pixel icon for the doc
    • 16@2x.png: a 32×32 pixel icon for the doc
    • SOURCE: A text file containing the URL to the page the image can be found on or the URL of the original image itself

Additional information: This required an update to Prism with OCaml highlighting.


image

@seirl seirl force-pushed the seirl:ocaml branch from 6757a04 to b51158f May 24, 2020
@seirl seirl force-pushed the seirl:ocaml branch from b51158f to db0746c May 24, 2020
@ELLIOTTCABLE
Copy link

@ELLIOTTCABLE ELLIOTTCABLE commented Jun 21, 2020

Anything in particular blocking this? I'd love to get it merged!

@s0kil
Copy link

@s0kil s0kil commented Jun 25, 2020

LGTM

@seirl
Copy link
Author

@seirl seirl commented Aug 10, 2020

Is there anything I can do to help get this merged?

@gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Aug 17, 2020

@j-f1 Can you review this ? thanks.

Copy link
Contributor

@simon04 simon04 left a comment

Thank you for this PR. Looking forward to seeing OCaml being present on devdocs. I did my bachelor and master projects in OCaml.

The HTML needs more cleanup (highlighted in red means to be cleaned/removed):

  • 2020-11-13-220027
  • 2020-11-13-215751
  • 2020-11-13-215845
  • 2020-11-13-215751
  • 2020-11-13-215928
  • please provide links to the original documentation (to be used with alt+o)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.