The Wayback Machine - https://web.archive.org/web/20220321123635/https://github.com/tiangolo/fastapi/pull/2192
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for Index #2192

Merged
merged 6 commits into from Dec 3, 2020
Merged

🌐 Add Korean translation for Index #2192

merged 6 commits into from Dec 3, 2020

Conversation

hard-coders
Copy link
Contributor

@hard-coders hard-coders commented Oct 18, 2020

This is the first translation for Korean Language page(see #2017), index.md.
I hope lots of developers who are Korean participate in this community.😁

And.. please review the translation, thanks.
@codecov
Copy link

@codecov codecov bot commented Oct 18, 2020 •
edited

Codecov Report

Merging #2192 (aa40595) into master (77f7447) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f7447...aa40595. Read the comment docs.
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 18, 2020

📝 Docs preview for commit b421847 at: https://5f8beb9334376794fb725200--fastapi.netlify.app
jrim
jrim approved these changes Oct 26, 2020
View changes
Copy link

@jrim jrim left a comment •
edited

It is absolutely well-translated. 너무 좋습니다!
hard-coders
hard-coders reviewed Nov 7, 2020
View changes
Copy link
Contributor Author

@hard-coders hard-coders left a comment •
edited

  • Replace "에티덄1�7" with "편집긄1�7" when translating "editor"
  • Add Sponsor section from a42c690
docs/ko/docs/index.md Outdated Show resolved Hide resolved
docs/ko/docs/index.md Outdated Show resolved Hide resolved
docs/ko/docs/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2020

📝 Docs preview for commit 45acc81 at: https://5fa6643418fb72b359c0a372--fastapi.netlify.app
@hard-coders hard-coders changed the title Add Korean translation for Index 🌐 Add Korean translation for Index Nov 21, 2020
swnim
swnim approved these changes Nov 26, 2020
View changes
hard-coders
hard-coders reviewed Nov 26, 2020
View changes
docs/ko/docs/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 26, 2020

📝 Docs preview for commit aa40595 at: https://5fbf63f7b5d07e408dd86be3--fastapi.netlify.app
@tiangolo
Copy link
Owner

@tiangolo tiangolo commented Dec 3, 2020

This is awesome! 🎉 🚀

Thanks a lot @hard-coders for all the work 🤓 🍰

And thanks @jrim and @swnim for the reviews 🙇 🍪
@tiangolo tiangolo merged commit 02b7d98 into tiangolo:master Dec 3, 2020
6 checks passed
@hard-coders hard-coders deleted the translation/ko-index branch Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 hacktoberfest-accepted lang-all lang-ko
4 participants
@hard-coders @tiangolo @jrim @swnim