The Wayback Machine - https://web.archive.org/web/20201222193425/https://github.com/pytorch/builder/pull/544
Skip to content

/ builder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add workflow to compile FFmpeg 4.2 on Windows #544

Merged
merged 25 commits into from Oct 12, 2020
Merged

PR: Add workflow to compile FFmpeg 4.2 on Windows #544

merged 25 commits into from Oct 12, 2020

Conversation

@andfoy
Copy link
Contributor

@andfoy andfoy commented Oct 8, 2020

This PR uses cross-compilation to compile FFmpeg on Windows with some dependencies that are not available on conda
andfoy added 14 commits Oct 8, 2020
@andfoy
Add workflow to compile FFmpeg 4.2 on Windows
Loading status checks…
3377e37
@andfoy
Single declaration for FFmpeg version
Loading status checks…
be2ca0f
@andfoy
Debug workspace persisting
Loading status checks…
431360d
@andfoy
Use specific tag
Loading status checks…
e230e9a
@andfoy
Minor version correction
Loading status checks…
230b21f
@andfoy
Persist ffmpeg binaries to workspace
Loading status checks…
e25640c
@andfoy
Persist tarball
Loading status checks…
ce766c2
@andfoy
Re-enable windows upload job
Loading status checks…
25ff00e
@andfoy
Make hold depend on ffmpeg_win
Loading status checks…
9438f38
@andfoy
Increase build parallelism
Loading status checks…
5465572
@andfoy
Use bash
Loading status checks…
54b22b5
@andfoy
Call dir
Loading status checks…
ad8fa31
@andfoy
Display temp folder
Loading status checks…
d8ffad1
@andfoy
Find tarball
Loading status checks…
fc8cd2a
@andfoy andfoy mentioned this pull request Oct 9, 2020
Open
andfoy added 10 commits Oct 9, 2020
@andfoy
Try installing local file
8bb1679
@andfoy
The file is tar.gz
Loading status checks…
56cac12
@andfoy
Debug SHA
Loading status checks…
fd8670b
@andfoy
Export SHA
Loading status checks…
4a991ab
@andfoy
Extract only the SHA256
Loading status checks…
96cb656
@andfoy
Try to filter non-conda binaries
Loading status checks…
aee5831
@andfoy
Remove robocopy
Loading status checks…
3528af4
@andfoy
Do not overwrite already existing files
Loading status checks…
cedae45
@andfoy
Store conda artifacts
Loading status checks…
b133274
@andfoy
Bump build
Loading status checks…
6aeb8e5
@seemethere
Copy link
Member

@seemethere seemethere commented Oct 12, 2020

Oh looks like we may have run into an issue with the workspaces overwriting themselves:

https://app.circleci.com/pipelines/github/pytorch/builder/900/workflows/5923a629-532e-4cd6-aa98-90fc11808049/jobs/19374

Concurrent upstream jobs persisted the same file(s) into the workspace:
  - output/noarch/current_repodata.json
  - output/noarch/repodata.json.bz2
  - output/noarch/index.html
  - output/hello
  - output/noarch/repodata.json
  - output/index.html
  - output/noarch/current_repodata.json.bz2
  - output/channeldata.json
  - output/noarch/repodata_from_packages.json
  - output/noarch/repodata_from_packages.json.bz2
@andfoy
Fix ffmpeg collisions
Loading status checks…
f2e1edf
@seemethere seemethere merged commit aa0228e into pytorch:master Oct 12, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: ffmpeg_upload CircleCI is running your tests
Details
ci/circleci: ffmpeg/hold Your job was approved on CircleCI!
Details
ci/circleci: ffmpeg_build_win Your tests passed on CircleCI!
Details
ci/circleci: ffmpeg_linux Your tests passed on CircleCI!
Details
ci/circleci: ffmpeg_mac Your tests passed on CircleCI!
Details
ci/circleci: ffmpeg_win Your tests passed on CircleCI!
Details
@seemethere
Copy link
Member

@seemethere seemethere commented Oct 12, 2020

New packages have been uploaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@andfoy @seemethere
You can’t perform that action at this time.