The Wayback Machine - https://web.archive.org/web/20201019101839/https://github.com/TheAlgorithms/Python/pull/3318
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert recent changes to .pre-commit-config.yaml #3318

Merged
merged 2 commits into from Oct 15, 2020
Merged

Revert recent changes to .pre-commit-config.yaml #3318

merged 2 commits into from Oct 15, 2020

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

We must continue to insist that algorithmic functions can not print() as discussed in CONTRIBUTING.md.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@cclauss
Revert recent changes to .pre-commit-config.yaml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f7e4db5 
We must continue to insist that algorithmic functions can not print() as discussed in CONTRIBUTING.md.
@cclauss cclauss requested a review from dhruvmanila Oct 15, 2020
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
eae6fa4
This was referenced Oct 15, 2020
Merged
Merged
@dhruvmanila
dhruvmanila approved these changes Oct 15, 2020
View changes
@dhruvmanila dhruvmanila merged commit 7c5cc28 into master Oct 15, 2020
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
Gitpod Open an online workspace in Gitpod
Details
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 15, 2020

Hey @cclauss,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d95a9850-0ed8-11eb-9bff-abeacd856cb9
@cclauss cclauss deleted the Revert-.pre-commit-config.yaml branch Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@cclauss @TravisBuddy @dhruvmanila
You can’t perform that action at this time.