The Wayback Machine - https://web.archive.org/web/20220321135340/https://github.com/tiangolo/fastapi/pull/2153
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add Japanese translation for Tutorial - Security - First Steps #2153

Conversation

komtaki
Copy link
Contributor

@komtaki komtaki commented Oct 10, 2020

This PR translates the tutorial/security/first-steps.md to Japanese.

According to the issue: #1572

I merged the PR for dependency: #1656
So, please check the commit : 18f28de

Thanks!!

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2020

📝 Docs preview for commit 18f28de1e84cc3484a7258d738c1083363bccce2 at: https://5f81b378b8a91f84cb2a5ca9--fastapi.netlify.app

@komtaki komtaki force-pushed the translation/add-japanese-doc-security-first-step branch from 18f28de to d50a9fc Compare Oct 10, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 10, 2020

Codecov Report

Merging #2153 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca9cc3...4de1bbe. Read the comment docs.

@komtaki komtaki marked this pull request as ready for review Oct 10, 2020
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2020

📝 Docs preview for commit d50a9fc8405722f34445ab91aa1a4271482548e9 at: https://5f81c1bb1a19b4907d0812a2--fastapi.netlify.app

Copy link
Contributor

@Attsun1031 Attsun1031 left a comment

Thank you for your tough work!
Please check comments I made.

docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
@komtaki
Copy link
Contributor Author

@komtaki komtaki commented Oct 11, 2020

@Attsun1031

Thank you for your review. 👍
I applied your suggestion. So, check please.

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 11, 2020

📝 Docs preview for commit 905fd553c2a1c51915bf6dcad5b397d17faf9622 at: https://5f82e8bf158e4bb48deff0f2--fastapi.netlify.app

Copy link
Contributor

@Attsun1031 Attsun1031 left a comment

LGTM 👍

komtaki and others added 3 commits Oct 19, 2020
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@komtaki komtaki force-pushed the translation/add-japanese-doc-security-first-step branch from 905fd55 to 819787a Compare Oct 19, 2020
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 19, 2020

Copy link
Contributor

@tokusumi tokusumi left a comment

Thank you for tough work! I commented some improvements (there are a too tiny changes 😅 )

docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved

**FastAPI**は、これらのセキュリティ機能を実装するために、抽象度の異なる複数のツールを提供しています。

この例では、**Bearer**トークンを使用して**OAuth2****パスワード**フローで使用します。これには`OAuth2PasswordBearer`クラスを使用します。
Copy link
Contributor

@tokusumi tokusumi Oct 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password flowの訳は「パスワードのフロー」か「パスワードフロー」のどちらかに統一したほうがいいと思います。後者の方が適切に感じます。

Copy link
Contributor Author

@komtaki komtaki Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

統一しました 🙇

docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
docs/ja/docs/tutorial/security/first-steps.md Outdated Show resolved Hide resolved
komtaki and others added 2 commits Nov 2, 2020
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@komtaki
Copy link
Contributor Author

@komtaki komtaki commented Nov 2, 2020

@tokusumi

Thanks for your review. I applied your suggestions and fixed. 👍
So, check please.

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 2, 2020

Copy link
Contributor

@tokusumi tokusumi left a comment

LGTM!

@tiangolo tiangolo changed the title Add tutorial/security/first-steps.md Japanese ver. 📝 Add Japanese translation for Tutorial - Security - First Steps Nov 5, 2020
@tiangolo tiangolo merged commit 104ee63 into tiangolo:master Nov 5, 2020
6 checks passed
@tiangolo
Copy link
Owner

@tiangolo tiangolo commented Nov 5, 2020

Awesome, thank you @komtaki ! 🍰

And thanks @tokusumi and @Attsun1031 for the reviews! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment