Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMigrate to circle2 #161
Merged
Migrate to circle2 #161
Conversation
codeclimate-hermes
requested review from
maxjacobson
and removed request for
codeclimate-hermes
|
I think |
.circleci/config.yml
Outdated
| steps: | ||
| - checkout | ||
| - run: make image | ||
| - run: make citest |
maxjacobson
Mar 21, 2019
Contributor
per the failing build, it looks like this should be make test
per the failing build, it looks like this should be make test
|
Sorry this is WIP, requested review too eagerly. Wrapping up one more thing. And yes to both things |
Old branches will need to cherry pick this commit
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Validate owner |
ale7714
Mar 21, 2019
Author
Member
circle 1 has this nice feature https://github.com/codeclimate/codeclimate-rubocop/blob/master/circle.yml#L24.
Unfortunately not available in circle2 so we're the validation within the job itself.
circleci step halt is a nifty trick to exit the job without failing the build. I learn it from this post.
circle 1 has this nice feature https://github.com/codeclimate/codeclimate-rubocop/blob/master/circle.yml#L24.
Unfortunately not available in circle2 so we're the validation within the job itself.
circleci step halt is a nifty trick to exit the job without failing the build. I learn it from this post.
maxjacobson
Mar 21, 2019
Contributor
That is neat!
That is neat!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Old branches will need to cherry pick this commit