The Wayback Machine - https://web.archive.org/web/20201026024057/https://github.com/TheAlgorithms/Python/pull/2935
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solution for Project Euler: Problem 38 #2935

Open
wants to merge 3 commits into
base: master
from
Open

Add solution for Project Euler: Problem 38 #2935

wants to merge 3 commits into from
+84 −0

Conversation

@coryallegory
Copy link

@coryallegory coryallegory commented Oct 6, 2020 •
edited

Describe your change:

Adding a Python implementation for Project Euler problem 38
https://projecteuler.net/problem=38

Contributes to Issue #2695

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@coryallegory coryallegory force-pushed the coryallegory:master branch 2 times, most recently from 8401f47 to 69bbedb Oct 6, 2020
@coryallegory coryallegory changed the title add euler problem 38 Add solution for Project Euler: Problem 38 Oct 6, 2020
@coryallegory coryallegory force-pushed the coryallegory:master branch 3 times, most recently from d606d4c to af5d11a Oct 6, 2020
@dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Announcement:

@coryallegory

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.
@53jk1
53jk1 approved these changes Oct 22, 2020
View changes
@coryallegory
add euler problem 38
613e528
@coryallegory coryallegory force-pushed the coryallegory:master branch from af5d11a to d0097ea Oct 26, 2020
@coryallegory coryallegory requested a review from Kush1101 as a code owner Oct 26, 2020
@coryallegory
rename to sol2 as another has been accepted, euler solution guideline…
Loading status checks…
f9b18fa 
… updates
@coryallegory coryallegory force-pushed the coryallegory:master branch from 2b56574 to f9b18fa Oct 26, 2020
github-actions github-actions
updating DIRECTORY.md
ff356e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not meet Solution Guidelines Good first issue Status: Merge Conflicts Status: awaiting changes
3 participants
@coryallegory @53jk1 @dhruvmanila
You can’t perform that action at this time.