The Wayback Machine - https://web.archive.org/web/20201008213440/https://github.com/TheAlgorithms/Python/pull/2880
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solution for Project Euler problem 188 #2880

Open
wants to merge 5 commits into
base: master
from
Open

Add solution for Project Euler problem 188 #2880

wants to merge 5 commits into from

Conversation

@darkstar
Copy link

@darkstar darkstar commented Oct 5, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
darkstar added 2 commits Oct 5, 2020
@darkstar
Project Euler problem 188 solution
Loading status checks…
fc4a979
@darkstar
fix superscript notation
Loading status checks…
8e6dab9
@dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View changes
project_euler/problem_188/sol1.py Show resolved Hide resolved
project_euler/problem_188/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_188/sol1.py Outdated Show resolved Hide resolved
darkstar added 3 commits Oct 6, 2020
@darkstar
split out modexpt() function, and rename parameters
Loading status checks…
2fa521b
@darkstar
Add some more doctest, and add type hints
Loading status checks…
dcc9aa4
@darkstar
Add some reference links
Loading status checks…
bee3abf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested Type hints needs
2 participants
@darkstar @dhruvmanila
You can’t perform that action at this time.