The Wayback Machine - https://web.archive.org/web/20250603210401/https://github.com/TheAlgorithms/Python/pull/2638
Skip to content

Added Solution of Problem 38 of Project Euler #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

Ishan7390
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #2510 .
@Ishan7390 Ishan7390 changed the title Ishan7390 patch 1 Added Solution of Problem 38 of Project Euler Oct 2, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @Ishan7390,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 24b11b80-047a-11eb-a4bc-1b94c014fd22
@TravisBuddy
Copy link

Travis tests have failed

Hey @Ishan7390,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 1f6cc120-0483-11eb-a4bc-1b94c014fd22
@TravisBuddy
Copy link

Travis tests have failed

Hey @Ishan7390,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0e889420-0487-11eb-a4bc-1b94c014fd22
@spamegg1
Copy link
Contributor

spamegg1 commented Oct 2, 2020

@Ishan7390 Hey there,

pre-commit will fail without an empty line at the end of the file.

Travis says:

______________ ERROR collecting project_euler/problem_38/sol1.py _______________
/opt/python/3.8.3/lib/python3.8/doctest.py:939: in find
self._find(tests, obj, name, module, source_lines, globs, {})
../../../virtualenv/python3.8.3/lib/python3.8/site-packages/_pytest/doctest.py:529: in _find
doctest.DocTestFinder._find( # type: ignore
/opt/python/3.8.3/lib/python3.8/doctest.py:1001: in _find
self._find(tests, val, valname, module, source_lines,
../../../virtualenv/python3.8.3/lib/python3.8/site-packages/_pytest/doctest.py:529: in _find
doctest.DocTestFinder._find( # type: ignore
/opt/python/3.8.3/lib/python3.8/doctest.py:989: in _find
test = self._get_test(obj, name, module, globs, source_lines)
/opt/python/3.8.3/lib/python3.8/doctest.py:1073: in _get_test
return self._parser.get_doctest(docstring, globs, name,
/opt/python/3.8.3/lib/python3.8/doctest.py:675: in get_doctest
return DocTest(self.get_examples(string, name), globs,
/opt/python/3.8.3/lib/python3.8/doctest.py:689: in get_examples
return [x for x in self.parse(string, name)
/opt/python/3.8.3/lib/python3.8/doctest.py:651: in parse
self._parse_example(m, name, lineno)
/opt/python/3.8.3/lib/python3.8/doctest.py:709: in _parse_example
self._check_prompt_blank(source_lines, indent, name, lineno)
/opt/python/3.8.3/lib/python3.8/doctest.py:793: in _check_prompt_blank
raise ValueError('line %r of the docstring for %s '
E ValueError: line 8 of the docstring for project_euler.problem_38.sol1.is_pandigital lacks blank after >>>: '>>>is_pandigital()'

So the last part tells you what is wrong! You need to change >>>is_pandigital() to >>> is_pandigital()

Best of luck.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@Ishan7390

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale
Copy link

stale bot commented Dec 10, 2020

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark an issue or pull request stale.
4 participants