The Wayback Machine - https://web.archive.org/web/20201019101317/https://github.com/TheAlgorithms/Python/pull/3344
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BROKEN BUILD: Fix a failing precommit test #3344

Merged
merged 2 commits into from Oct 15, 2020
Merged

BROKEN BUILD: Fix a failing precommit test #3344

merged 2 commits into from Oct 15, 2020

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 2 commits Oct 15, 2020
@cclauss
Fix a failing precommit test
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4aa2755
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
148fdc0
@cclauss cclauss changed the title Fix a failing precommit test BROKEN BUILD: Fix a failing precommit test Oct 15, 2020
@Panquesito7
Panquesito7 approved these changes Oct 15, 2020
View changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Looks fine; good work. 👍
@cclauss cclauss merged commit 5b024f4 into master Oct 15, 2020
4 checks passed
4 checks passed
codespell
Details
pre-commit
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
@cclauss cclauss deleted the cclauss-patch-1 branch Oct 15, 2020
KumarUniverse added a commit to KumarUniverse/Python that referenced this pull request Oct 15, 2020
@KumarUniverse
Merge pull request #2 from TheAlgorithms/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a078c48 
BROKEN BUILD: Fix a failing precommit test (TheAlgorithms#3344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OK to merge enhancement
6 participants
@cclauss @Panquesito7 @poyea @shellhub @mateuszz0000 @dhruvmanila
You can’t perform that action at this time.