The Wayback Machine - https://web.archive.org/web/20201019101421/https://github.com/TheAlgorithms/Python/pull/2626
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math/extended_euclidean_algorithm: add doctests and support for negative numbers #2626

Merged
merged 6 commits into from Oct 7, 2020
Merged

math/extended_euclidean_algorithm: add doctests and support for negative numbers #2626

merged 6 commits into from Oct 7, 2020
+54 −41

Conversation

@pikulet
Copy link
Contributor

@pikulet pikulet commented Oct 1, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
pikulet added 2 commits Oct 1, 2020
@pikulet
add type hints to math/extended euclid
86d7e09
@pikulet
math/extended euclid - add doctest
Loading status checks…
c57736e
@pikulet pikulet changed the title add type hints to math/extended_euclidean_algorithm math/extended_euclidean_algorithm: add type hints and doctest Oct 1, 2020
@pikulet
math/extended euclid: remove manual doctest
Loading status checks…
cea02d9
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 2, 2020

As mentioned in #2630, can you make the appropriate changes for the algorithm to handle negative numbers?
@pikulet
change algorithm for negative numbers
Loading status checks…
478b0ac
@pikulet pikulet changed the title math/extended_euclidean_algorithm: add type hints and doctest math/extended_euclidean_algorithm: add doctests and support for negative numbers Oct 2, 2020
@pikulet
Copy link
Contributor Author

@pikulet pikulet commented Oct 2, 2020 •
edited

done. resolves #2630
@dhruvmanila
dhruvmanila reviewed Oct 5, 2020
View changes
maths/extended_euclidean_algorithm.py Outdated Show resolved Hide resolved
@dhruvmanila dhruvmanila linked an issue that may be closed by this pull request Oct 5, 2020
math/extended_euclidean_algorithm cannot properly handle negative numbers #2630
Closed
@dhruvmanila
dhruvmanila reviewed Oct 5, 2020
View changes
maths/extended_euclidean_algorithm.py Outdated Show resolved Hide resolved
@pikulet
improve naming of variables
Loading status checks…
9db6f67
@dhruvmanila
dhruvmanila requested changes Oct 7, 2020
View changes
maths/extended_euclidean_algorithm.py Outdated Show resolved Hide resolved
@dhruvmanila
Update extended_euclidean_algorithm.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b00b63d
@dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Thank you for your contribution!
@dhruvmanila dhruvmanila merged commit e41d041 into TheAlgorithms:master Oct 7, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@pikulet @dhruvmanila
You can’t perform that action at this time.