Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle(core): modify camelize error message #177
Conversation
File name can not be a pure number. If so, egg-core will throw an exception with a regular expression matching message which is confused.
test/loader/file_loader.test.js
Outdated
| @@ -225,7 +225,7 @@ describe('test/loader/file_loader.test.js', () => { | |||
| directory: path.join(dirBase, 'error/dotdir'), | |||
| target: mod, | |||
| }).load(); | |||
| }, /dot.dir is not match 'a-z0-9_-' in dot.dir\/a.js/); | |||
| }, 'dot.dir is not match \'^[a-z][a-z0-9_-]*$\' in dot.dir\/a.js'); | |||
popomore
Aug 16, 2018
Member
It should be reg
It should be reg
army8735
Aug 20, 2018
Author
Contributor
well done
well done
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 958 958
=====================================
Hits 958 958
Continue to review full report at Codecov.
|
| @@ -235,13 +235,13 @@ describe('test/loader/file_loader.test.js', () => { | |||
| directory: path.join(dirBase, 'error/underscore-dir'), | |||
| target: mod, | |||
| }).load(); | |||
| }, /_underscore is not match 'a-z0-9_-' in _underscore\/a.js/); | |||
| }, '_underscore is not match \'^[a-z][a-z0-9_-]*$\' in _underscore\/a.js'); | |||
dead-horse
Aug 27, 2018
Member
this line should be regexp
this line should be regexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
File name can not be a pure number.
If so, egg-core will throw an exception with a regular expression matching message which is confused.