Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for Elliptic Curve keys #8
Conversation
6e88258
to
b78ac9a
|
Hey @yonran. Sorry this has sat around so long. I would largely base the tests on the tests for the RSA versions of the classes you're adding. You can find these in As for how to run tests, you can install josepy and it's dependencies in a virtual environment by running commands like the following from the root of the repo:
After that, you can run tests with
You can replace 27 whichever Python version you want to test against as long as that version of Python is installed on your system. |
|
I would love to see this and #45 implemented, as ES256 is a MUST requirement for ACME. Quoting RFC 8555 Section 6.2 here:
|
|
Indeed it is a MUST for an ACME server. While the small Certbot team would also love to see this implemented, we probably won't be able to get to it for a little while. If you'd like to see it sooner, we'd accept well written PRs for these features. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Hi. I wanted to add EC support to certbot because I was using lego and wanted to switch my account to certbot. But lego created an account signed using EC instead of RSA so my account was stuck. I would like guidance on what tests I should write and how to run pylint/pydoc.