The Wayback Machine - https://web.archive.org/web/20201015070003/https://github.com/deis/workflow-cli/issues/289
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config:push with .env doesn't handle export or double quotes #289

Open
deis-admin opened this issue Jan 19, 2017 · 4 comments
Open

config:push with .env doesn't handle export or double quotes #289

deis-admin opened this issue Jan 19, 2017 · 4 comments
Labels

Comments

@deis-admin
Copy link

@deis-admin deis-admin commented Jan 19, 2017

From @glenwong on June 4, 2015 23:19

If you have environment variables in your .env file that are surrounded by double quotes or start with an export they aren't handled correctly when pushed to deis. For example:

export REDIS_URL="redis://localhost:6379"

ends up as

export REDIS_URL: "redis://localhost:6379"

Where "export REDIS_URL" is the key and the value is still surrounded by double quotes which can then cause things to fail when the config is referenced.

Copied from original issue: deis/deis#3796

@deis-admin
Copy link
Author

@deis-admin deis-admin commented Jan 19, 2017

From @mboersma on June 10, 2015 21:24

Are env vars containing spaces in their names legal on Heroku? If not, we should tighten the .env file validation rules; if so, we should probably document config:push and config:pull behavior more specifically around this case.

@deis-admin
Copy link
Author

@deis-admin deis-admin commented Jan 19, 2017

From @bacongobbler on June 18, 2016 7:14

same answer as I laid out in deis/deis#4512; we should move to a shared library or follow the spec laid out in https://github.com/bkeepers/dotenv#usage.

@jeroenvisser101
Copy link

@jeroenvisser101 jeroenvisser101 commented Jan 26, 2017

We're had the same bug a few times. Locally they work fine using Foreman, but in prod they fail.

@Cryptophobia
Copy link

@Cryptophobia Cryptophobia commented Mar 21, 2018

This issue was moved to teamhephy/workflow-cli#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.