Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Release 5.1.0 - main #522
Merged
Release 5.1.0 - main #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mikepenz
commented
Oct 11, 2020
- [release] v5.1.0
- update all font addons to use jetpack app startup
no message
Pass the value of attribute "ico_automirror" to the IconicsDrawable
* showcase databinding usage * FIX #462
* update to alpha of AboutLibraries for test purposes
* split into 4 icon sets for each 1000 icons to not run into compile issues * FIX #482
* release new communit material icons library v4.7.95.3
- cleanup import - use drawable for test purposes also in ImageView - set minSdk to 16 again
…resources and the theme. - instead of needing a context, keep theme and resources which will be used to resolve colors / ... - this is the initial phase of this refactor, more cleanup is needed.
- move all producers to producer extensions - add all convenient setters to the IconicsDrawableExtensions.kt - introduce new optimized apply functions which will not invalidate while updating properties - refactor all code to use new properties - update to MaterialDrawer v8 - update to FastAdapter v5 - update to AboutLibraries v8
- fix and simplify array builder - revert iconics brush back to original - some more cleanup
- improve release script
- implementation 'com.mikepenz:community-material-typeface:3.7.95.4-kotlin@aar'
# Conflicts: # app/src/main/java/com/mikepenz/iconics/sample/PlaygroundActivity.kt
- update material lib - update aboutlibraries
- simplify code - udpate to latest aboutlibraries
- fix drawer icon colors
![github-actions[bot]](https://web.archive.org/web/20220509205048im_/https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| android:textColor="@android:color/black" | ||
| android:padding="5dp" | ||
| android:layout_marginTop="8dp" | ||
| android:text="Button/IconicsButton Showcase" /> |
There was a problem hiding this comment.
Hardcoded string "Button/IconicsButton Showcase", should use @string resource |
| android:layout_width="0dp" | ||
| android:layout_height="60dp" | ||
| android:layout_weight="1" | ||
| android:text="{faw-adjust} Button" /> |
There was a problem hiding this comment.
Hardcoded string "{faw-adjust} Button", should use @string resource |
| android:layout_width="0dp" | ||
| android:layout_height="60dp" | ||
| android:layout_weight="1" | ||
| android:text="{fon-test2} Button" /> |
There was a problem hiding this comment.
Hardcoded string "{fon-test2} Button", should use @string resource |
| android:layout_weight="1" | ||
| android:text="{fon-test2} Button" /> | ||
|
|
||
| <ImageButton |
There was a problem hiding this comment.
Missing contentDescription attribute on image |
| app:iiv_bottom_icon="gmd_add_circle_outline" | ||
| app:iiv_bottom_color="@color/md_blue_grey_300" | ||
| app:iiv_bottom_size="24dp" | ||
| android:text="IconicsButton with side-drawables" |
There was a problem hiding this comment.
Hardcoded string "IconicsButton with side-drawables", should use @string resource |
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="8dp" | ||
| android:text="ImageView Showcase" /> |
There was a problem hiding this comment.
Hardcoded string "ImageView Showcase", should use @string resource |
| android:text="BottomNavigationView Showcase" /> | ||
| android:orientation="horizontal"> | ||
|
|
||
| <ImageView |
There was a problem hiding this comment.
Missing contentDescription attribute on image |
| android:layout_width="48dp" | ||
| android:layout_height="48dp" /> | ||
|
|
||
| <ImageView |
There was a problem hiding this comment.
Missing contentDescription attribute on image |
| android:layout_width="48dp" | ||
| android:layout_height="48dp" /> | ||
|
|
||
| <ImageView |
There was a problem hiding this comment.
Missing contentDescription attribute on image |
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="8dp" | ||
| android:text="IconicsCheckBox Showcase" /> |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckBox Showcase", should use @string resource |
| <com.mikepenz.iconics.view.IconicsCheckBox | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="IconicsCheckBox" |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckBox", should use @string resource |
| <com.mikepenz.iconics.view.IconicsCheckBox | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="Iconics{fon-test1}CheckBox{faw-adjust}" |
There was a problem hiding this comment.
Hardcoded string "Iconics{fon-test1}CheckBox{faw-adjust}", should use @string resource |
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="8dp" | ||
| android:text="IconicsCheckableTextView Showcase" /> |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckableTextView Showcase", should use @string resource |
| <com.mikepenz.iconics.view.IconicsCheckableTextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="IconicsCheckableTextViewStart" |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckableTextViewStart", should use @string resource |
| <com.mikepenz.iconics.view.IconicsCheckableTextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="IconicsCheckableTextViewTop" |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckableTextViewTop", should use @string resource |
| <com.mikepenz.iconics.view.IconicsCheckableTextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="IconicsCheckableTextViewEnd" |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckableTextViewEnd", should use @string resource |
| <com.mikepenz.iconics.view.IconicsCheckableTextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="IconicsCheckableTextViewBottom" |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckableTextViewBottom", should use @string resource |
| <com.mikepenz.iconics.view.IconicsCheckableTextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="IconicsCheckableTextView" |
There was a problem hiding this comment.
Hardcoded string "IconicsCheckableTextView", should use @string resource |
| app:itemIconTint="@color/color_states_bottom_navigation_icons" | ||
| app:menu="@menu/menu_navigation" /> | ||
| android:layout_marginTop="8dp" | ||
| android:text="BottomNavigationView Showcase" /> |
There was a problem hiding this comment.
Hardcoded string "BottomNavigationView Showcase", should use @string resource |
| return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { | ||
| res.getColorStateList(colorRes, theme) | ||
| } else { | ||
| res.getColorStateList(colorRes) |
There was a problem hiding this comment.
Use AppCompatResources.getColorStateList() |
| import android.content.Context | ||
| import com.mikepenz.iconics.typeface.utils.IconicsPreconditions | ||
|
|
||
| /** |
There was a problem hiding this comment.
Do not place Android context classes in static fields (static reference to IconicsHolder which has field context pointing to Context); this is a memory leak |
| * @author pa.gulko zTrap (02.05.2020) | ||
| */ | ||
| object IconicsHolder { | ||
| private var context: Context? = null |
There was a problem hiding this comment.
| Do not place Android context classes in static fields; this is a memory leak |
Generated by |
| android:layout_width="72dp" | ||
| android:layout_height="72dp" | ||
| android:padding="24dp" | ||
| app:tint="@color/accent" |
There was a problem hiding this comment.
Must use app:tint instead of android:tint |
| android:layout_width="72dp" | ||
| android:layout_height="72dp" | ||
| android:padding="24dp" | ||
| app:tint="@color/accent" |
There was a problem hiding this comment.
Must use app:tint instead of android:tint |
| <item name="colorPrimaryDark">@color/primary_dark</item> | ||
| <item name="colorAccent">@color/accent</item> | ||
|
|
||
| <!-- CAB :D --> |
There was a problem hiding this comment.
android:windowTranslucentStatus requires API level 19 (current min is 16) |
|
|
||
| <!-- CAB :D --> | ||
| <item name="windowActionModeOverlay">true</item> | ||
|
|
There was a problem hiding this comment.
android:statusBarColor requires API level 21 (current min is 16) |
| <!-- CAB :D --> | ||
| <item name="windowActionModeOverlay">true</item> | ||
|
|
||
| <item name="toolbarStyle">@style/CustomToolbarStyle</item> |
There was a problem hiding this comment.
android:navigationBarColor requires API level 21 (current min is 16) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.