Problem:

A common pattern is:

GUARD(s2n_stuffer_skip_write(stuffer, bytes_to_write));
uint8_t* ptr = suffer->blob.data + stuffer->write_cursor - bytes_to_write;

which could be simplified.

Solution:

*ptr could be an *out parameter to s2n_stuffer_skip_write

• Does this change what S2N sends over the wire? No.
• Does this change any public APIs? No.

Type: Potential Documentation Issue
OS: Windows, latest vcpkg version - mbedtls 2.16.3-1

Minimal example:

const unsigned char key[]	= { 0x15, 0x1, 0xc0, 0xd0, 0xe4, 0xfd, 0xdf, 0xd7, 0x7a, 0x65, 0xf1, 0x2f, 0x45, 0x61, 0xb, 0x59, 0xd9, 0xa, 0x9c, 0x61, 0xc, 0x4, 0x76, 0xdb, 0xb, 0xbe, 0x9e, 0xe4, 0x7f, 0x8d, 0xe1, 0x46 };
unsigned char		data[]	= { 0x3b, 0xb1, 0x99, 0x3, 0x67, 0xf3, 0x2e

https://scotthelme.co.uk/a-new-security-header-feature-policy/

I guess it will be easy to add, because we certainly don't use any of these features.
Or maybe "gyroscope" or so may be used by the random number generator in sjcl, but that's all.

Please add provider support for the "botan encryption" command and implement the needed AES operations with PKCS#11.
I could not find any command line tool that I can use for that. OpenSSL's PKCS#11 engine does not support AES either.