The Wayback Machine - https://web.archive.org/web/20201007211218/https://github.com/TheAlgorithms/Python/pull/2702
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest: Add a solution for Project Euler 49 #2702

Merged
merged 16 commits into from Oct 5, 2020
Merged

Hacktoberfest: Add a solution for Project Euler 49 #2702

merged 16 commits into from Oct 5, 2020

Conversation

@Iqrar99
Copy link
Contributor

@Iqrar99 Iqrar99 commented Oct 3, 2020 •
edited

Seperated the PR based on #2548

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Iqrar99 and others added 12 commits Feb 20, 2020
@Iqrar99
added doctests in modular_exponential.py
0da5cea
@Iqrar99
Merge branch 'master' of https://github.com/Iqrar99/Python
e658085
@Iqrar99
added doctests in modular_exponential.py
Loading status checks…
4183239
@Iqrar99
added URL link
Loading status checks…
3856fa0
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
82aed44
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
d3a4913
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
b4e33ab
@Iqrar99
Merge branch 'master' of https://github.com/TheAlgorithms/Python
133838c
github-actions github-actions
updating DIRECTORY.md
56990e6
@Iqrar99
Add problem 49 solution
f13bba5
@Iqrar99
Merge branch 'pe-49' of https://github.com/Iqrar99/Python into pe-49
723f832
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
b92d14f
@dhruvmanila
dhruvmanila requested changes Oct 4, 2020
View changes
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_49/sol1.py Show resolved Hide resolved
project_euler/problem_49/sol1.py Show resolved Hide resolved
project_euler/problem_49/sol1.py Show resolved Hide resolved
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
@Iqrar99
Copy link
Contributor Author

@Iqrar99 Iqrar99 commented Oct 4, 2020

Thanks for the review @dhruvmanila. I'll make the changes soon.
Iqrar99 added 2 commits Oct 4, 2020
@Iqrar99
Fix several mistakes
c748482 
These fixes are intended to follow the CONTRIBUTING.md
@Iqrar99
Merge branch 'pe-49' of https://github.com/Iqrar99/Python into pe-49
Loading status checks…
27abe3f
@Iqrar99 Iqrar99 requested a review from dhruvmanila Oct 4, 2020
@dhruvmanila
dhruvmanila requested changes Oct 4, 2020
View changes
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
@Iqrar99
Move the import statements lower
Loading status checks…
771c736
@Iqrar99 Iqrar99 requested a review from dhruvmanila Oct 5, 2020
@dhruvmanila
dhruvmanila requested changes Oct 5, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Looks good to me! Thank you for your contribution. 🎉 😃
project_euler/problem_49/sol1.py Outdated Show resolved Hide resolved
@Iqrar99 @dhruvmanila
Update project_euler/problem_49/sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
05c9a36 
Co-authored-by: Dhruv <[email protected]>
@Iqrar99
Copy link
Contributor Author

@Iqrar99 Iqrar99 commented Oct 5, 2020

Looks good to me! Thank you for your contribution. 🎉 😃

You are welcome! Maybe you want to review my Project Euler 50 PR? @dhruvmanila here #2703
@Iqrar99 Iqrar99 requested a review from dhruvmanila Oct 5, 2020
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 5, 2020

Sure thing, but please keep this in mind that we receive a lot of PRs and if possible only submit one PR at a time and once that is approved, submit another one.

The ocean is made up of tiny droplets of water
@Iqrar99
Copy link
Contributor Author

@Iqrar99 Iqrar99 commented Oct 5, 2020

I see. Take your time 😄
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 5, 2020

Are you participating in Hacktoberfest? If so, please include for Hacktoberfest in the description of your PR to signal us.
@dhruvmanila
dhruvmanila approved these changes Oct 5, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

#2695
@Iqrar99 Iqrar99 changed the title Add a solution for Project Euler 49 Hacktoberfest: Add a solution for Project Euler 49 Oct 5, 2020
@dhruvmanila dhruvmanila merged commit e040ad2 into TheAlgorithms:master Oct 5, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@Iqrar99
Copy link
Contributor Author

@Iqrar99 Iqrar99 commented Oct 5, 2020

Thank you so much 😄 I'm looking forward to contributing more!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted
2 participants
@Iqrar99 @dhruvmanila
You can’t perform that action at this time.