The Wayback Machine - https://web.archive.org/web/20201008210115/https://github.com/TheAlgorithms/Python/pull/3050
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Project Euler] Fix code style for problem 56 #3050

Merged
merged 3 commits into from Oct 8, 2020
Merged

[Project Euler] Fix code style for problem 56 #3050

merged 3 commits into from Oct 8, 2020
+16 −4

Conversation

@Aman333Saxena
Copy link
Contributor

@Aman333Saxena Aman333Saxena commented Oct 8, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Aman333Saxena and others added 2 commits Oct 8, 2020
@Aman333Saxena
rename method for project_euler/problem #56
Loading status checks…
2761b12
@dhruvmanila
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2dacfdb
@dhruvmanila dhruvmanila changed the title rename method for project_euler/problem #56 [Project Euler] Fix code style for problem 56 Oct 8, 2020
@dhruvmanila
Removed whitespaces
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
31030ee
@dhruvmanila
dhruvmanila approved these changes Oct 8, 2020
View changes
@dhruvmanila dhruvmanila merged commit c9500dc into TheAlgorithms:master Oct 8, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Aman333Saxena @dhruvmanila
You can’t perform that action at this time.