The Wayback Machine - https://web.archive.org/web/20201008212932/https://github.com/TheAlgorithms/Python/pull/2962
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default args and type hints for Project Euler problem 20 #2962

Merged
merged 1 commit into from Oct 7, 2020
Merged

Add default args and type hints for Project Euler problem 20 #2962

merged 1 commit into from Oct 7, 2020
+25 −16

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 7, 2020

Continuing #2786

  • Improved variable names
  • Added type hints
  • Added default argument values for validate_solutions script

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
@dhruvmanila
Add type hints and default args for problem 20
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
66d358b 
- Improved variable names
- Added type hints
- Added default argument values for validate_solutions script
@dhruvmanila dhruvmanila requested a review from Kush1101 Oct 7, 2020
@dhruvmanila dhruvmanila requested a review from shellhub Oct 7, 2020
@shellhub
shellhub approved these changes Oct 7, 2020
View changes
Copy link
Member

@shellhub shellhub left a comment •
edited

LGTM
@shellhub shellhub merged commit 11a5afd into TheAlgorithms:master Oct 7, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@dhruvmanila dhruvmanila deleted the dhruvmanila:patch-problem-20 branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need Reviews
2 participants
@dhruvmanila @shellhub
You can’t perform that action at this time.