The Wayback Machine - https://web.archive.org/web/20201008213430/https://github.com/TheAlgorithms/Python/pull/2632
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Corrected test. List in test must be ordered. #2632

Merged
merged 2 commits into from Oct 7, 2020
Merged

Fix: Corrected test. List in test must be ordered. #2632

merged 2 commits into from Oct 7, 2020

Conversation

@NumberPiOso
Copy link
Contributor

@NumberPiOso NumberPiOso commented Oct 2, 2020 •
edited

What the title says.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • [ X All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@NumberPiOso
Fix: Corrected test. List in test must be ordered.
Unverified
The email in this signature doesn’t match the committer email.
GPG key ID: E8B96E8EBACC45CD Learn about signing commits
Loading status checks…
8e94aa6
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 2, 2020

Awesome! Thanks for pointing this out. Can you add a few more random tests by using range and different step values? Maybe we can use sorted(random.choices(range(-n, +n), k=100)) to select 100 pseudo-random numbers from a list of 1000 numbers ranging from negative to positive.
@poyea poyea self-assigned this Oct 2, 2020
@NumberPiOso
Copy link
Contributor Author

@NumberPiOso NumberPiOso commented Oct 4, 2020

@poyea are you working in this one? or should I propose the next commit ?
@poyea
Copy link
Member

@poyea poyea commented Oct 4, 2020

You may consider adding the test cases suggested. I'll review it once you've done.
@NumberPiOso
Copy link
Contributor Author

@NumberPiOso NumberPiOso commented Oct 5, 2020

@dhruvmanila could you please elaborate a little more that idea?
In particular, how do I know in advance if the number is in the list.

>>> n = 500
>>> print(binary_search(sorted(random.choices(range(-n, +n), k=100)), 100))
>>> ?
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 5, 2020

Ah, did not see that. Sorry about that. A better option would be to just use random(range(-100, 100, <step_value>)) or something like that. Put whichever step value you think would be good enough.
@NumberPiOso
Add tests with big lists.
Loading status checks…
d7adf39
@dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Looks good! Thank you for your contribution!
@dhruvmanila dhruvmanila merged commit 40db8c2 into TheAlgorithms:master Oct 7, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@NumberPiOso NumberPiOso deleted the NumberPiOso:simp_binary branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@NumberPiOso @dhruvmanila @poyea
You can’t perform that action at this time.