The Wayback Machine - https://web.archive.org/web/20201008210530/https://github.com/TheAlgorithms/Python/pull/2443
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphs/kruskal: add a test case to verify the correctness, fix styles #2443

Merged
merged 7 commits into from Oct 8, 2020
Merged

graphs/kruskal: add a test case to verify the correctness, fix styles #2443

merged 7 commits into from Oct 8, 2020
+58 −18

Conversation

@meysam81
Copy link
Contributor

@meysam81 meysam81 commented Sep 17, 2020

And also to increase the coverage as stated in #2128

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@meysam81
test/graphs/kruskal: adding a test case to verify the correctness of …
Loading status checks…
c8bba8f 
…the algorithm

Fixes #2128
@cclauss
cclauss reviewed Sep 17, 2020
View changes
graphs/minimum_spanning_tree_kruskal.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 17, 2020
View changes
graphs/tests/test_min_spanning_tree_kruskal.py Outdated
[3, 5, 14],
[3, 4, 9],
[5, 4, 10],
[1, 7, 11]]

This comment has been minimized.

Sign in to view
@cclauss

cclauss Sep 17, 2020
Member

psf/black will reformat the matrices.
meysam81 and others added 2 commits Sep 18, 2020
@meysam81
grahps/kruskal: running psf/black
Loading status checks…
e2c958f
@meysam81 @cclauss
graphs/kruskal: read edges in a friendlier fashion
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4d3fb7e 
Co-authored-by: Christian Clauss <[email protected]>
@poyea poyea self-assigned this Oct 1, 2020
@poyea
Update minimum_spanning_tree_kruskal.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6ca51e4
@github-actions github-actions bot force-pushed the meysam81:test/graphs/kruskal branch from b9182d6 to 41efee1 Oct 8, 2020
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
06d69bb
@github-actions github-actions bot force-pushed the meysam81:test/graphs/kruskal branch from 41efee1 to 06d69bb Oct 8, 2020
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 8, 2020

Travis tests have failed

Hey @meysam81,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 327c6100-095e-11eb-b9d6-41d4da7e5060
poyea and others added 2 commits Oct 8, 2020
@poyea
Update test_min_spanning_tree_kruskal.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
07e9514
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
9a119cf
@poyea poyea changed the title test/graphs/kruskal: adding a test case to verify the correctness of the algorithm graphs/kruskal: add a test case to verify the correctness, fix styles Oct 8, 2020
@poyea
poyea approved these changes Oct 8, 2020
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩
@poyea poyea added the OK to merge label Oct 8, 2020
@poyea poyea merged commit c2a5033 into TheAlgorithms:master Oct 8, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 8, 2020

No type hints or doctests.
@poyea
Copy link
Member

@poyea poyea commented Oct 8, 2020

Right we can add some type hints to this file @meysam81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OK to merge
4 participants
@meysam81 @TravisBuddy @cclauss @poyea
You can’t perform that action at this time.