The Wayback Machine - https://web.archive.org/web/20201008065258/https://github.com/weechat/scripts/pull/420
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fish.py key exchange #420

Open
wants to merge 6 commits into
base: master
from
Open

Fix fish.py key exchange #420

wants to merge 6 commits into from

Conversation

@wikro
Copy link
Contributor

@wikro wikro commented Aug 2, 2020

Exchanging keys with current version of fish.py (0.9.4) results in errors because sometimes bytes objects are passed to functions, sometimes string objects.

@flashcode flashcode added the bug label Aug 2, 2020
@wikro
Copy link
Contributor Author

@wikro wikro commented Aug 2, 2020

@rr- Your repo was a bit old, hence why I sent a PR straight here

@flashcode
Copy link
Member

@flashcode flashcode commented Sep 6, 2020

Hi,
There are no changes in this pull request?

@flashcode flashcode self-assigned this Sep 6, 2020
@wikro
Copy link
Contributor Author

@wikro wikro commented Sep 7, 2020

The changes were merged to master on Aug 2. If you check the commits you can see my changes. I also saw change #425, which fixes my fix even further, and probably more correctly.

@Xtravaganz
Copy link

@Xtravaganz Xtravaganz commented Sep 15, 2020

Someone has the knowledge to add a CBC mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.