The Wayback Machine - https://web.archive.org/web/20201007210234/https://github.com/TheAlgorithms/Python/pull/2946
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added computer vision algorithm #2946

Open
wants to merge 3 commits into
base: master
from
Open

Added computer vision algorithm #2946

wants to merge 3 commits into from
+34 −0

Conversation

@TanayKarve
Copy link

@TanayKarve TanayKarve commented Oct 6, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
TanayKarve added 3 commits Oct 6, 2020
@TanayKarve
Create meanthresholding.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
1b62c0e
@TanayKarve
Rename meanthresholding.py to meanthreshold.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b0b8532
@TanayKarve
Update meanthreshold.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa9f68f
@sharpblade4
Copy link
Contributor

@sharpblade4 sharpblade4 commented Oct 7, 2020

@TanayKarve you can optimize it in magnitudes by using numpy vectorian oprerations instead of python for loops
@TanayKarve
Copy link
Author

@TanayKarve TanayKarve commented Oct 7, 2020 •
edited

@sharpblade4 yes i was planning to do it, however wanted to write this code in pure python, thus avoiding any dependencies. what do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@TanayKarve @sharpblade4
You can’t perform that action at this time.