The Wayback Machine - https://web.archive.org/web/20201007211111/https://github.com/TheAlgorithms/Python/pull/2882
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints for "strings" folder #2882

Merged
merged 3 commits into from Oct 6, 2020
Merged

Add type hints for "strings" folder #2882

merged 3 commits into from Oct 6, 2020
+23 −16

Conversation

@DmytroLitvinov
Copy link
Contributor

@DmytroLitvinov DmytroLitvinov commented Oct 5, 2020 •
edited

Describe your change:

This PR adds type hints into strings/ folder.
Related to issue #2128

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • [] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@DmytroLitvinov
Copy link
Contributor Author

@DmytroLitvinov DmytroLitvinov commented Oct 5, 2020

Friendly ping @dhruvmanila 👀
@DmytroLitvinov DmytroLitvinov changed the title Add type hints for strings/ Add type hints for "strings" folder Oct 5, 2020
@dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View changes
strings/aho_corasick.py Outdated Show resolved Hide resolved
strings/aho_corasick.py Outdated Show resolved Hide resolved
strings/aho_corasick.py Outdated Show resolved Hide resolved
strings/boyer_moore_search.py Outdated Show resolved Hide resolved
strings/knuth_morris_pratt.py Outdated Show resolved Hide resolved
@github-actions github-actions bot force-pushed the DmytroLitvinov:type-hints-strings branch from 917f773 to c06a6a3 Oct 6, 2020
@DmytroLitvinov DmytroLitvinov force-pushed the DmytroLitvinov:type-hints-strings branch from e6cbe9d to 477b2c2 Oct 6, 2020
@DmytroLitvinov
Add type hints for strings/ folder
Verified
This commit was signed with a verified signature.
DmytroLitvinov Dmytro Litvinov
GPG key ID: 805E7168ADCA1743 Learn about signing commits
Loading status checks…
a5794be
@DmytroLitvinov DmytroLitvinov reopened this Oct 6, 2020
@DmytroLitvinov DmytroLitvinov force-pushed the DmytroLitvinov:type-hints-strings branch from 0e64a07 to a5794be Oct 6, 2020
@DmytroLitvinov DmytroLitvinov requested a review from dhruvmanila Oct 6, 2020
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 6, 2020

What happened in here lol?
You will have to make an empty commit for other checks to run as right now only Travis CI ran.
@DmytroLitvinov
Rerun other checks
Verified
This commit was signed with a verified signature.
DmytroLitvinov Dmytro Litvinov
GPG key ID: 805E7168ADCA1743 Learn about signing commits
Loading status checks…
92a5b7a
@DmytroLitvinov DmytroLitvinov force-pushed the DmytroLitvinov:type-hints-strings branch from e0f39f2 to 92a5b7a Oct 6, 2020
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
368e735
@DmytroLitvinov
Copy link
Contributor Author

@DmytroLitvinov DmytroLitvinov commented Oct 6, 2020

@dhruvmanila, after pushing empty commit - 2 other checks were running. The result of their running is updating DIRECTORY.md.
@DmytroLitvinov
Copy link
Contributor Author

@DmytroLitvinov DmytroLitvinov commented Oct 6, 2020

@dhruvmanila , seems like it is okay.

Selection_356
Selection_357
@dhruvmanila
dhruvmanila approved these changes Oct 6, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Alright then it's fine. Thank you for your contribution!
@dhruvmanila dhruvmanila merged commit 000cedc into TheAlgorithms:master Oct 6, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@DmytroLitvinov DmytroLitvinov deleted the DmytroLitvinov:type-hints-strings branch Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested
2 participants
@DmytroLitvinov @dhruvmanila
You can’t perform that action at this time.