The Wayback Machine - https://web.archive.org/web/20201007211125/https://github.com/TheAlgorithms/Python/pull/2849
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed coding style problem 33 fixes: #2786 #2849

Open
wants to merge 1 commit into
base: master
from
Open

Fixed coding style problem 33 fixes: #2786 #2849

wants to merge 1 commit into from
+7 −7

Conversation

@bobluppes
Copy link

@bobluppes bobluppes commented Oct 5, 2020 •
edited

Describe your change:

Changed the function name to solution for project euler problem 33.

  • Add an algorithm?
  • [ x ] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ x ] I have read CONTRIBUTING.md.
  • [ x ] This pull request is all my own work -- I have not plagiarized.
  • [ x ] I know that pull requests will not be merged if they fail the automated tests.
  • [ x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x ] All new Python files are placed inside an existing directory.
  • [ x ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ x ] All functions and variable names follow Python naming conventions.
  • [ x ] All function parameters and return values are annotated with Python type hints.
  • [ x ] All functions have doctests that pass the automated testing.
  • [ x ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@bobluppes
Fixed coding style problem 33 fixes: #2786
Loading status checks…
3782829
@dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View changes
project_euler/problem_33/sol1.py
@@ -23,17 +23,17 @@ def isDigitCancelling(num, den):
return True


def solve(digit_len: int) -> str:
def solution(digit_len: int) -> str:

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 6, 2020
Member

Please add the default value for the parameter digit_len such that when called without any arguments solution() returns the right answer to the solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested
2 participants
@bobluppes @dhruvmanila
You can’t perform that action at this time.