The Wayback Machine - https://web.archive.org/web/20201125010258/https://github.com/TheAlgorithms/Python/pull/2627
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math/sieve_of_eratosthenes: add type hints #2627

Merged
merged 6 commits into from Nov 23, 2020
Merged

math/sieve_of_eratosthenes: add type hints #2627

merged 6 commits into from Nov 23, 2020

Conversation

@pikulet
Copy link
Contributor

@pikulet pikulet commented Oct 1, 2020 •
edited

Describe your change:

just for completeness of existing code to follow the (now compulsory) requirements of type hints

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
pikulet added 2 commits Oct 1, 2020
@pikulet
add type hints to math/sieve
60e0dfe
@pikulet
add doctest
Loading status checks…
70d6f14
@pikulet pikulet changed the title math/sieve of eras: add type hitns and doctest math/sieve_of_eratosthenes: add type hints and doctest Oct 1, 2020
@pikulet
math/sieve: remove manual doctest
Loading status checks…
3522b05
@pikulet pikulet changed the title math/sieve_of_eratosthenes: add type hints and doctest math/sieve_of_eratosthenes: add type hints Oct 2, 2020
@pikulet
add check for negative
Loading status checks…
1f376e8
@53jk1
53jk1 approved these changes Oct 22, 2020
View changes
@stale
Copy link

@stale stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the stale label Nov 21, 2020
@dhruvmanila
dhruvmanila requested changes Nov 23, 2020
View changes
maths/sieve_of_eratosthenes.py Outdated Show resolved Hide resolved
@stale stale bot removed the stale label Nov 23, 2020
@dhruvmanila
Update maths/sieve_of_eratosthenes.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9dacd49
@dhruvmanila dhruvmanila requested a review from Kush1101 as a code owner Nov 23, 2020
@dhruvmanila dhruvmanila removed the request for review from Kush1101 Nov 23, 2020
@dhruvmanila
Update sieve_of_eratosthenes.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
75801d8
@dhruvmanila
dhruvmanila approved these changes Nov 23, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Thank you for your contribution!
@dhruvmanila dhruvmanila merged commit 03e7f37 into TheAlgorithms:master Nov 23, 2020
2 checks passed
2 checks passed
build
Details
pre-commit
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@pikulet @53jk1 @dhruvmanila
You can’t perform that action at this time.