The Wayback Machine - https://web.archive.org/web/20201019101117/https://github.com/TheAlgorithms/Python/pull/2598
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in the evaluate postfix notation using Stack #2598

Merged
merged 12 commits into from Oct 16, 2020
Merged

Adding in the evaluate postfix notation using Stack #2598

merged 12 commits into from Oct 16, 2020

Conversation

@akashgkrishnan
Copy link
Contributor

@akashgkrishnan akashgkrishnan commented Oct 1, 2020 •
edited

Describe your change:

Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@akashgkrishnan
Create evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c848c3c 
Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks
@akashgkrishnan
Create evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
0ac6611 
Adding in the evaluate postfix notation using Stacks
one of the common use with simple stack question
creating a new file for the data structure of stacks
@akashgkrishnan
Delete evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
73f61b2
@poyea
Copy link
Member

@poyea poyea commented Oct 1, 2020

Please change the PR's title to something more meaningful.
@akashgkrishnan
Evaluate postfix expression stack clean approach
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e9334a1 
Sending in the PR again as the Previous request failed in pre commit
@akashgkrishnan akashgkrishnan changed the title Patch 6 Adding in the evaluate postfix notation using Stack Oct 1, 2020
@akashgkrishnan
Update evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1351128
@akashgkrishnan akashgkrishnan requested a review from cclauss as a code owner Oct 13, 2020
@akashgkrishnan
Update evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e1eb21 
Made changes as per the required for fixing the failing pre-commits.
@cclauss
cclauss reviewed Oct 15, 2020
View changes
data_structures/stacks/evaluate_postfix_notations.py Outdated
@@ -1,12 +1,24 @@
'''

This comment has been minimized.

Sign in to view
@cclauss

cclauss Oct 15, 2020
Member

This is called a docstring which explains the intent of this file. The docstring is used by pydoc if you run the command python3 -m pydoc data_structures/stacks/evaluate_postfix_notations.py

By converting this to a comment, this PR would remove that documentation.
@cclauss
cclauss reviewed Oct 15, 2020
View changes
data_structures/stacks/evaluate_postfix_notations.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Oct 15, 2020
View changes
data_structures/stacks/evaluate_postfix_notations.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

https://docs.python.org/3/library/operator.html makes dealing with these probems much easier.
@cclauss
cclauss reviewed Oct 15, 2020
View changes
data_structures/stacks/evaluate_postfix_notations.py Outdated Show resolved Hide resolved
@akashgkrishnan
Update evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e1c15e9 
Made changes as suggested by @cclauss
@akashgkrishnan
Copy link
Contributor Author

@akashgkrishnan akashgkrishnan commented Oct 15, 2020

thanks, @cclauss for the detailed review. However, pre commits are still failing. I'll update and recommit
@akashgkrishnan
Update evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e0b8cb 
fixed pre-commit fails
@akashgkrishnan
Update evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3668d56 
fixing pre-commit fails
@cclauss
cclauss reviewed Oct 16, 2020
View changes
data_structures/stacks/evaluate_postfix_notations.py Outdated Show resolved Hide resolved
@akashgkrishnan
Update evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f63309 
Deleted trailing white spaces causing pre-commits to fail
@cclauss
cclauss reviewed Oct 16, 2020
View changes
data_structures/stacks/evaluate_postfix_notations.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Oct 16, 2020
View changes
data_structures/stacks/evaluate_postfix_notations.py Outdated Show resolved Hide resolved
akashgkrishnan and others added 2 commits Oct 16, 2020
@akashgkrishnan @cclauss
Update data_structures/stacks/evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
29530ed 
Co-authored-by: Christian Clauss <[email protected]>
@akashgkrishnan @cclauss
Update data_structures/stacks/evaluate_postfix_notations.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
22393cf 
Co-authored-by: Christian Clauss <[email protected]>
@akashgkrishnan
Copy link
Contributor Author

@akashgkrishnan akashgkrishnan commented Oct 16, 2020

@cclauss sir is there something else that needs to be fixed in this?
@cclauss
cclauss approved these changes Oct 16, 2020
View changes
@cclauss cclauss merged commit 7d84f7f into TheAlgorithms:master Oct 16, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@akashgkrishnan akashgkrishnan deleted the akashgkrishnan:patch-6 branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated tests are failing
3 participants
@akashgkrishnan @poyea @cclauss
You can’t perform that action at this time.