The Wayback Machine - https://web.archive.org/web/20201007205038/https://github.com/TheAlgorithms/Python/pull/2978
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #2786 - Fix code style in Project Euler Problem 76 #2978

Merged
merged 4 commits into from Oct 7, 2020
Merged

Address #2786 - Fix code style in Project Euler Problem 76 #2978

merged 4 commits into from Oct 7, 2020
+14 −13

Conversation

@JoanRosell
Copy link
Contributor

@JoanRosell JoanRosell commented Oct 7, 2020 •
edited

Signed-off-by: joan.rosellr joan.rosellr@gmail.com

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
JoanRosell and others added 4 commits Oct 7, 2020
@JoanRosell
fix code style in problem 76
Loading status checks…
6e22b3b 
Signed-off-by: joan.rosellr <joan.rosellr@gmail.com>
@dhruvmanila
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3234539
@dhruvmanila
Update sol1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1a13262
@dhruvmanila
Remove trailing whitespace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a7d2d04
@dhruvmanila
dhruvmanila approved these changes Oct 7, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Thank you for your contribution!
@dhruvmanila dhruvmanila merged commit c14cfa3 into TheAlgorithms:master Oct 7, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@JoanRosell JoanRosell deleted the JoanRosell:project-euler-76 branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@JoanRosell @dhruvmanila
You can’t perform that action at this time.