The Wayback Machine - https://web.archive.org/web/20201006210951/https://github.com/TheAlgorithms/Python/pull/2493
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update insert sort #2493

Merged
merged 4 commits into from Oct 3, 2020
Merged

Update insert sort #2493

merged 4 commits into from Oct 3, 2020

Conversation

@shellhub
Copy link
Member

@shellhub shellhub commented Sep 26, 2020

update insert sort

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@shellhub
delete duplicate file
Loading status checks…
1e13cd4 
update insert sort
@shellhub shellhub requested a review from cclauss Sep 26, 2020
@nomisrevol
nomisrevol reviewed Sep 28, 2020
View changes
sorts/insertion_sort.py Outdated Show resolved Hide resolved
@shellhub shellhub requested review from nomisrevol and poyea Sep 28, 2020
@shellhub shellhub force-pushed the shellhub:insert_sort branch from 86ccc69 to 1e13cd4 Oct 3, 2020
@shellhub shellhub requested a review from dhruvmanila Oct 3, 2020
shellhub added 2 commits Oct 3, 2020
@shellhub
rename
Loading status checks…
a7833f2
@shellhub
fixed error
Loading status checks…
bb4952e
@shellhub
Copy link
Member Author

@shellhub shellhub commented Oct 3, 2020 •
edited

@cclauss @nomisrevol @poyea @dhruvmanila Build passed. I think this PR can be merged now.
@shellhub
using enumerate()
Loading status checks…
e2f56a9
@shellhub
Copy link
Member Author

@shellhub shellhub commented Oct 3, 2020

@cclauss @nomisrevol @poyea @dhruvmanila Do you have time to review this ?
@dhruvmanila
dhruvmanila approved these changes Oct 3, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Sorry, I got busy then.
Looks good. Awesome work!
@dhruvmanila dhruvmanila removed request for cclauss, nomisrevol and poyea Oct 3, 2020
@dhruvmanila dhruvmanila dismissed nomisrevol’s stale review Oct 3, 2020

The changes requested has been made by the author.

@dhruvmanila dhruvmanila merged commit 43f9249 into TheAlgorithms:master Oct 3, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@shellhub shellhub deleted the shellhub:insert_sort branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@shellhub @cclauss @nomisrevol @dhruvmanila
You can’t perform that action at this time.