Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix coin change #2571
Merged
Fix coin change #2571
Conversation
Co-authored-by: Tapajyoti Bose <[email protected]>
|
Is it really a useful contribution? |
dynamic_programming/coin_change.py
Outdated
| >>> dp_count([1, 2, 3], -5) | ||
| 0 | ||
| >>> dp_count([4, 5, 6], -4) | ||
| 0 | ||
| >>> dp_count([2, 5, 3, 6], -10) | ||
| 0 | ||
| >>> dp_count([4], -4) | ||
| 0 |
Comment on lines
22
to
29
poyea
Oct 1, 2020
Member
Suggested change
>>> dp_count([1, 2, 3], -5)
0
>>> dp_count([4, 5, 6], -4)
0
>>> dp_count([2, 5, 3, 6], -10)
0
>>> dp_count([4], -4)
0
>>> dp_count([1, 2, 3], -5)
0
I think 1 test case for this is enough.
Suggested change
| >>> dp_count([1, 2, 3], -5) | |
| 0 | |
| >>> dp_count([4, 5, 6], -4) | |
| 0 | |
| >>> dp_count([2, 5, 3, 6], -10) | |
| 0 | |
| >>> dp_count([4], -4) | |
| 0 | |
| >>> dp_count([1, 2, 3], -5) | |
| 0 |
I think 1 test case for this is enough.
poyea
Oct 5, 2020
Member
I mean to test the < 0 line, one test case is enough. You may add some larger test cases too to demonstrate the correctness.
I mean to test the < 0 line, one test case is enough. You may add some larger test cases too to demonstrate the correctness.
|
Can you change the title of the pull request to something like |
Closed
|
@poyea done the changes have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Describe your change:
Removed unused variable and modified code for coin_chainge algo.
Checklist:
Fixes: #{$ISSUE_NO}.