The Wayback Machine - https://web.archive.org/web/20201006210430/https://github.com/TheAlgorithms/Python/pull/2924
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Euler Problem 10: style improvements #2924

Merged
merged 1 commit into from Oct 6, 2020
Merged

Project Euler Problem 10: style improvements #2924

merged 1 commit into from Oct 6, 2020
+68 −48

Conversation

@vovapi
Copy link
Contributor

@vovapi vovapi commented Oct 6, 2020 •
edited

Describe your change:

Style improvements for Project Euler Problem 10

  • Rename the main solution functions to solution.
  • Rename prime check functions to is_prime.
  • Add default args, typehints, expand variable names.

Related to #2786

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@vovapi
Project Euler Problem 10: style improvements
Loading status checks…
b0de6f7 
Rename the main solution functions to solution.
Rename prime chec functions to is_prime.
Add default args, typehints, expand variable names.
@vovapi vovapi force-pushed the vovapi:euler-10-style branch from 73bebb6 to b0de6f7 Oct 6, 2020
@dhruvmanila
dhruvmanila approved these changes Oct 6, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Perfecto! Thank you for doing this! :)
@dhruvmanila dhruvmanila merged commit e74adc4 into TheAlgorithms:master Oct 6, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted
2 participants
@vovapi @dhruvmanila
You can’t perform that action at this time.