The Wayback Machine - https://web.archive.org/web/20201006210619/https://github.com/TheAlgorithms/Python/pull/2522
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update temperature_conversions.py #2522

Merged
merged 3 commits into from Oct 3, 2020
Merged

Update temperature_conversions.py #2522

merged 3 commits into from Oct 3, 2020

Conversation

@SabariGanesh-K
Copy link
Contributor

@SabariGanesh-K SabariGanesh-K commented Sep 30, 2020 •
edited

Added Reaumur scale unit conversions.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@SabariGanesh-K
Update temperature_conversions.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b2117e8 
Added Reaumur scale unit conversions.
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Sep 30, 2020

Hey @SabariGanesh-K,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1d3873f0-032e-11eb-8abf-036a378110f7
@SabariGanesh-K
Update temperature_conversions.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
27ffc96
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Sep 30, 2020

Hey @SabariGanesh-K,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 88ed9570-032f-11eb-8abf-036a378110f7
@SabariGanesh-K
Update temperature_conversions.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2ffd0dc
@SabariGanesh-K
Copy link
Contributor Author

@SabariGanesh-K SabariGanesh-K commented Oct 3, 2020

Its working now and I have fixed it.All 3 checks have been verified.
I am adding a new temperature unit called Reaumur.
Kindly verify it.
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 3, 2020

This is looking good! Awesome work!
It seems you can do the conversion in a reverse way as well. If you wish to add the functions for that, you can do so and if not then it's fine. Inform me about your decision so that I can review your PR.

Celsius -> Réaumur
kelvin -> Réaumur
...
@SabariGanesh-K
Copy link
Contributor Author

@SabariGanesh-K SabariGanesh-K commented Oct 3, 2020

Thanks for the appreciation. I am leaving the reverse way as an chance for other people so that they can fill it if they find that it is missing. And let me know if you want the reverse way as well, so that I can commit it too. If my decision of giving others a chance is fine , you may merge it.
@dhruvmanila
dhruvmanila approved these changes Oct 3, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Alright, no problem. It's your decision.

  • Formulas are correct
  • Includes doctest
  • Passing all automated tests

Congratulation on your first commit! 🎉 😁
@dhruvmanila dhruvmanila merged commit e9865ae into TheAlgorithms:master Oct 3, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@SabariGanesh-K
Copy link
Contributor Author

@SabariGanesh-K SabariGanesh-K commented Oct 3, 2020

Thanks once again😀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@SabariGanesh-K @TravisBuddy @dhruvmanila
You can’t perform that action at this time.